Re: Announcing Release 6 of PostgreSQL Buildfarm client

On 01/04/2018 12:51 PM, Tom Lane wrote:
> I wrote:
>> which means I get mail every time the cron script runs. Needless
>> to say, that will not do. Previously, mail only showed up when
>> there was a git checkout failure. How do I get back to the
>> old behavior?
> Diff'ing the v5 and v6 releases soon provided the answer: for some
> reason v6 is forcing the verbose switch on. I hope that was
> unintentional? Anyway, I'm happy again after applying this patch:
>
> --- PGBuild/Options.pm~ 2018-01-04 08:38:29.000000000 -0500
> +++ PGBuild/Options.pm 2018-01-04 12:40:14.000000000 -0500
> @@ -78,8 +78,6 @@
> GetOptions(%standard_options, @_)
> || die "bad command line";
>
> - # override GetOptions default for :i
> - $verbose = 1 if (defined($verbose) && $verbose==0);
> $verbose ||= 0; # stop complaints about undefined var in numeric comparison
> }
>
>
>

What is weird is that the only change has been to move this from
run_build.pl into PGBuild::Options::fetch_options. Those two lines have
been in run_build.pl for many years:

2cdd46ae    (Andrew Dunstan 2004-09-24 20:22:32 +0000   111)$verbose=1
if (defined($verbose) && $verbose==0);
4307d647    (Andrew Dunstan 2005-12-23 16:55:53 +0000   112)$verbose ||=
0; # stop complaints about undefined var in numeric comparison

and the lines you showed come from run_build.pl.

The rationale for the move was to make the flag sanely available to
other programs, specifically run_branches.pl.

So it's very odd. I'll do some experimenting.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services