Re: [PATCH] Logical decoding of TRUNCATE

From: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Logical decoding of TRUNCATE
Date: 2018-01-23 14:38:45
Message-ID: de2a9d73-1e25-797c-03f8-9faa57f75e85@2ndquadrant.it
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-general pgsql-hackers

Il 22/01/18 23:18, Petr Jelinek ha scritto:
> On 22/01/18 19:45, Petr Jelinek wrote:
>
> Actually on second look, I don't like the new boolean parameter much.
> I'd rather we didn't touch the input list and always close only
> relations opened inside the ExecuteTruncateGuts().
>
> It may mean more list(s) but the current interface is still not clean.
>

Now ExecuteTruncateGuts unconditionally closes the relations that it
opens. The caller has now always the responsibility to close the
relations passed with the explicit_rels list.

Version 15 attached.

Regards,
Marco

--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco(dot)nenciarini(at)2ndQuadrant(dot)it | www.2ndQuadrant.it

Attachment Content-Type Size
0001-truncate_ignore_fks_role_replica.v4.patch text/plain 2.8 KB
0002-logical_decode_truncate.v15.patch text/plain 53.8 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Petr Jelinek 2018-01-23 17:13:09 Re: [PATCH] Logical decoding of TRUNCATE
Previous Message Adrian Klaver 2018-01-23 14:03:37 Re: Changing locale/charset

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2018-01-23 14:42:45 Re: Handling better supported channel binding types for SSL implementations
Previous Message Robert Haas 2018-01-23 14:35:23 Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan