From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, andres(at)anarazel(dot)de, petr(dot)jelinek(at)2ndquadrant(dot)com, pet(dot)slavov(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, petr(at)2ndquadrant(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #15114: logical decoding Segmentation fault |
Date: | 2019-01-30 11:22:15 |
Message-ID: | de2a118a-6f07-4689-0ff8-0c8dc2a23d3c@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On 29/01/2019 08:59, Michael Paquier wrote:
> On Mon, Jan 28, 2019 at 10:32:16PM +0100, Peter Eisentraut wrote:
>> My approach is to make RelationGetIndexAttrBitmap() not need a snapshot.
>> The whole code was overly complicated anyway, calling BuildIndexInfo()
>> and then throwing the result away. We can do it directly more
>> efficiently and avoid all the business about eval_const_expressions().
>> Moreover, this fixes the problem in a central place and does not require
>> bespoke separate fixes in the publisher and subscriber code. External
>> logical decoding or logical replication implementations could also be
>> affected and would benefit from this fix.
>
> I have spent some time for the last couple of days looking at this
> patch, and that's a neat approach.
>
> + * those might run constants evaluation, which needs a snapshot, which
> "constants evaluation" sounds like weird English. "constant
> evaluation" or "evaluation of constants would be better"?
Committed and backpatched with your and Noah's changes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2019-01-30 12:31:56 | Re: BUG #15613: Bug in PG Planner for Foreign Data Wrappers |
Previous Message | PG Bug reporting form | 2019-01-30 09:46:44 | BUG #15613: Bug in PG Planner for Foreign Data Wrappers |