| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Underscores in numeric literals |
| Date: | 2023-01-31 15:28:48 |
| Message-ID: | de21d0dc-cc09-430d-f74e-1121028632cf@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.01.23 21:45, Dean Rasheed wrote:
> On Wed, 4 Jan 2023 at 09:28, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>>
>> In addition, I think that strip_underscores() could then go away if
>> numeric_in() were made to handle underscores.
>>
>> Essentially then, that would move all responsibility for parsing
>> underscores and non-decimal integers to the datatype input functions,
>> or their support routines, rather than having it distributed.
>
> Here's an update with those changes.
This looks good to me.
Did you have any thoughts about what to do with the float types? I
guess we could handle those in a separate patch?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilya Gladyshev | 2023-01-31 15:32:20 | Re: Progress report of CREATE INDEX for nested partitioned tables |
| Previous Message | Joel Jacobson | 2023-01-31 15:05:28 | Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt(). |