Re: PostgresNode::append_conf considered dangerous

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: PostgresNode::append_conf considered dangerous
Date: 2017-04-23 00:56:28
Message-ID: de19724f-63cb-8298-9cda-298c239984f0@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/22/2017 04:19 PM, Tom Lane wrote:
>
> I think instead we should change append_conf to append a newline, and
> simplify the callers that could thereby be simplified. I don't see
> any callers that would be broken by that; and we do not have any config
> files in which extra blank lines are problematic.
>
>

+1. Not sure how we survived so long with it the way it is.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-04-23 01:15:40 Re: logical replication and PANIC during shutdown checkpoint in publisher
Previous Message Andres Freund 2017-04-23 00:19:31 Re: StandbyRecoverPreparedTransactions recovers subtrans links incorrectly