Re: Making background psql nicer to use in tap tests

On 2023-03-17 Fr 18:58, Andres Freund wrote:
> Hi,
>
> On 2023-03-17 12:25:14 -0400, Andrew Dunstan wrote:
>> On 2023-03-17 Fr 10:08, Daniel Gustafsson wrote:
>>>> If we are going to keep this as a separate package, then we should put some code in the constructor to prevent it being called from elsewhere than the Cluster package. e.g.
>>>>
>>>> # this constructor should only be called from PostgreSQL::Test::Cluster
>>>> my ($package, $file, $line) = caller;
>>>> die "Forbidden caller of constructor: package: $package, file: $file:$line"
>>>> unless $package eq 'PostgreSQL::Test::Cluster';
>>> I don't have strong feelings about where to place this, but Cluster.pm is
>>> already quite long so I see a small upside to keeping it separate to not make
>>> that worse.
>>>
>> Yeah, I can go along with that.
> Cool - I'd prefer a separate file. I do find Cluster.pm somewhat unwieldy at
> this point, and I susect that we'll end up with additional helpers around
> BackgroundPsql.
>

Yeah. BTW, a better test than the one above would be

   $package->isa("PostgreSQL::Test::Cluster")

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com