| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree |
| Date: | 2022-01-18 21:17:26 |
| Message-ID: | ddb2a03b-d192-88ad-03d0-5b8c6559ae44@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/18/22 15:08, Juan José Santamaría Flecha wrote:
>
>
>
> > By the way, are pgbison.bat and pgflex.bat directly called anywhere?
>
> Not to my knowledge. One of the things that's annoying about them is
> that the processor names are hardcoded, so if you install winflexbison
> as I usually do you have to rename the executables (or rename the
> chocolatey shims) or the scripts won't work.
>
> We could use those batches to get to the hardcoded name, but that
> would probably be as annoying as renaming. If those batches serve no
> purpose right now, it should be fine to remove them from the tree. I
> use the executables from a MinGW installation, and they keep their
> actual name.
>
OK, but I don't think we should require installation of MinGW for an
MSVC build.
cheers
andrew
--
Andrew Dunstan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-01-18 21:22:36 | Re: SQL/JSON: functions |
| Previous Message | Justin Pryzby | 2022-01-18 21:08:47 | Re: Adding CI to our tree |