Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: 孙诗浩(思才) <sunshihao(dot)ssh(at)alibaba-inc(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: 范孝剑(康贤) <funnyxj(dot)fxj(at)alibaba-inc(dot)com>
Subject: Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch
Date: 2021-08-11 10:10:14
Message-ID: dd2c10c5-8f5b-8997-aaad-0da60703e61c@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 8/10/21 11:27 PM, 孙诗浩(思才) wrote:
>      we can use regular expressions (<>|!=) to cover "<>" and "!=".
> There is no
> need to have two definitions less_greater and not_equals, because it
> will confuse developer.
> So, we can use only not_equals to cover this operator set.
>
>

I don't understand the problem being solved here. This looks like a
change with no discernable benefit. I don't agree that the current code
is substantially more likely to confuse developers. And the lexer is not
something that gets a lot of change.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-08-11 11:04:42 Re: Next Steps with Hash Indexes
Previous Message Daniel Gustafsson 2021-08-11 08:42:09 Re: Small documentation improvement for ALTER SUBSCRIPTION