| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improper use about DatumGetInt32 |
| Date: | 2020-11-30 14:50:46 |
| Message-ID: | dcfd8024-41c3-90f2-16d8-c6d3b6ca14e9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-27 13:37, Ashutosh Bapat wrote:
> Yeah, I had it like that for a moment, but then you need to duplicate
> the check in get_raw_page() and get_raw_page_fork(). I figured since
> get_raw_page_internal() does all the other argument checking also, it
> seems sensible to put the block range check there too. But it's not a
> big deal either way.
>
>
> FWIW, my 2c. Though I agree with both sides, I
> prefer get_raw_page_internal() accepting BlockNumber, since that's what
> it deals with and not the entire int8.
Patch updated this way. I agree it's better that way.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pageinspect-Change-block-number-arguments-to-bigi.patch | text/plain | 13.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2020-11-30 15:06:28 | Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs |
| Previous Message | Alvaro Herrera | 2020-11-30 14:48:26 | Re: pgbench - test whether a variable exists |