| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DROP SUBSCRIPTION, query cancellations and slot handling |
| Date: | 2017-04-21 02:34:40 |
| Message-ID: | dcda5ee4-336c-7ae9-932f-103cc750c63c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/04/17 23:30, Peter Eisentraut wrote:
> On 4/20/17 10:19, Petr Jelinek wrote:
>> Hmm well since this only affects the synchronization of table
>> states/names, I guess we could just simply do that before we create the
>> slot as there is no expectancy of consistency between slot and the table
>> list snapshot.
>
> I suppose that wouldn't hurt.
>
> Prior to the table sync patch, a missing target relation would just show
> up as an error later on in the logs. So having the error sooner
> actually seems like a good change.
>
Very simple patch to make.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| Synchronize-table-list-before-creating-slot-in-CREAT.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-04-21 02:37:20 | Re: walsender & parallelism |
| Previous Message | Craig Ringer | 2017-04-21 02:32:02 | Re: walsender & parallelism |