From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |
Date: | 2024-05-12 11:53:17 |
Message-ID: | dcccf6bb-8a4e-4318-870a-e78252a5f0b2@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 14.12.23 14:40, Nazir Bilal Yavuz wrote:
> On Fri, 6 Oct 2023 at 17:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> As a quick cross-check, I searched our commit log to see how many
>> README-only commits there were so far this year. I found 11 since
>> January. (Several were triggered by the latest round of pgindent
>> code and process changes, so maybe this is more than typical.)
>>
>> Not sure what that tells us about the value of changing the CI
>> logic, but it does seem like it could be worth the one-liner
>> change needed to teach buildfarm animals to ignore READMEs.
>
> I agree that it could be worth implementing this logic on buildfarm animals.
>
> In case we want to implement the same logic on the CI, I added a new
> version of the patch; it skips CI completely if the changes are only
> in the README files.
I don't see how this could be applicable widely enough to be useful:
- While there are some patches that touch on README files, very few of
those end up in a commit fest.
- If someone manually pushes a change to their own CI environment, I
don't see why we need to second-guess that.
- Buildfarm runs generally batch several commits together, so it is very
unlikely that this would be hit.
I think unless some concrete reason for this change can be shown, we
should drop it.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-05-12 11:57:43 | Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS |
Previous Message | Peter Eisentraut | 2024-05-12 11:46:29 | Re: Add TAP tests for backtrace functionality (was Re: Add test module for verifying backtrace functionality) |