| From: | Vik Fearing <vik(at)postgresfriends(dot)org> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tracking last scan time |
| Date: | 2022-09-30 15:58:31 |
| Message-ID: | dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/7/22 12:03, Dave Page wrote:
> Here's a v4 patch. This reverts to using
> GetCurrentTransactionStopTimestamp() for the last_scan times, and will
> set xactStopTimestamp the first time GetCurrentTransactionStopTimestamp()
> is called, thus avoiding multiple gettimeofday() calls.
> SetCurrentTransactionStopTimestamp() is removed, as is use
> of xactStopTimestamp (except when resetting it to 0).
This patch looks good to me and has much saner behavior than what it
replaces.
As a matter of process, the oid for the new function should be in the
8000-9000 range and the catversion should be bumped by the committer.
Marked as Ready for Committer. Thanks for the patch!
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-30 15:59:53 | Re: [PATCH v1] [meson] add a default option prefix=/usr/local/pgsql |
| Previous Message | Masahiko Sawada | 2022-09-30 15:46:54 | Re: [PoC] Improve dead tuple storage for lazy vacuum |