| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, amul sul <sulamul(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in pg_dump --table and --exclude-table for declarative partition table handling. |
| Date: | 2017-05-09 09:43:19 |
| Message-ID: | dc20d807-1e72-49a8-ac0d-c119631ba9b9@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/05/09 17:21, Jeevan Ladhe wrote:
> On Tue, May 9, 2017 at 12:43 PM, amul sul <sulamul(at)gmail(dot)com> wrote:
>> Current pg_dump --exclude-table option excludes partitioned relation
>> and dumps all its child relations and vice versa for --table option, which
>> I think is incorrect.
>>
>> In this case we might need to explore all partitions and exclude or include
>> from dump according to given pg_dump option, attaching WIP patch proposing
>> same fix. Thoughts/Comments?
>
> Also, I can see similar issue exists with inheritance.
> In attached patch, I have extended Amul's original patch to address the
> inheritance dumping issue.
Perhaps, it will be better not to touch the regular inheritance tables in
this patch.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-05-09 09:44:42 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
| Previous Message | Ashutosh Bapat | 2017-05-09 09:40:14 | Re: Bug in pg_dump --table and --exclude-table for declarative partition table handling. |