Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

From: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>
To: David Steele <david(at)pgmasters(dot)net>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line
Date: 2019-03-07 12:27:25
Message-ID: dbddb1ad-b7ee-25fb-21ce-a0a92f939f9e@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 07.03.2019 10:26, David Steele wrote:
> On 3/6/19 5:38 PM, Andrey Borodin wrote:
>>
>> The new patch is much smaller (less than 400 lines) and works as
>> advertised.
>> There's a typo "retreive" there.

Ough, corrected this in three different places. Not my word, definitely.
Thanks!

>>
>> These lines look a little suspicious:
>>         char  postgres_exec_path[MAXPGPATH],
>>                   postgres_cmd[MAXPGPATH],
>>                   cmd_output[MAX_RESTORE_COMMAND];
>> Is it supposed to be any difference between MAXPGPATH and
>> MAX_RESTORE_COMMAND?
>>

Yes, it was supposed to be, but after your message I have double checked
everything and figured out that we use MAXPGPATH for final
restore_command build (with all aliases replaced). Thus, there is no
need in a separated constant. I have replaced it with MAXPGPATH.

>
> This patch appears to need attention from the author so I have marked
> it Waiting on Author.
>

I hope I have addressed all issues in the new patch version which is
attached. Also, I have added more detailed explanation of new
functionality into the multi-line commit-message.

Regards,

--
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
v5-0001-pg_rewind-options-to-use-restore_command.patch text/x-patch 19.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2019-03-07 12:35:03 Re: Update does not move row across foreign partitions in v11
Previous Message David Steele 2019-03-07 12:23:53 Re: Optimization of some jsonb functions