Nothing is using StrategyNotifyBgWriter() anymore

From: Jim Nasby <nasbyj(at)amazon(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Nothing is using StrategyNotifyBgWriter() anymore
Date: 2022-06-16 22:30:14
Message-ID: db6343d7-6f2e-11dc-d512-d9c250af19c1@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While browsing through some of the clock-sweep code I noticed that the
only place StrategyNotifyBgWriter() is called now is in
BackgroundWriterMain()[1]. Presumably this isn't what's desired. If
nothing else, it means the function's description comment is wrong, as
are comments in BackgroundWriterMain(). This isn't new; 9.2 shows the
same thing and that's when the function was added. I'm not sure what the
right fix here is, since ISTM joggling bgwriter for every call to
BufferAlloc() would be overkill.

1:
https://doxygen.postgresql.org/freelist_8c.html#aabbd7d3891afc1d8531c3871d08d4b28

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nasby, Jim 2022-06-16 22:53:27 Re: Nothing is using StrategyNotifyBgWriter() anymore
Previous Message Imseih (AWS), Sami 2022-06-16 21:32:26 Re: [PROPOSAL] Detecting plan changes with plan_id in pg_stat_activity