Re: explain analyze rows=%.0f

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
Subject: Re: explain analyze rows=%.0f
Date: 2025-03-11 09:58:06
Message-ID: db14cd95-f00d-4824-aebb-81c7e5a7ca08@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In the stats_ext regression test, there is a function
check_estimated_rows that returns actual rows as an integer. Currently,
none of the test cases produce a non-zero fractional part in actual rows.

The question is: should this function be modified to return a fractional
number instead of an integer?

Personally, I don’t see much value in doing so, because the purpose of
the test is to compare the estimated row count with the actual number of
rows. It is also unlikely that there will be test cases where loops > 1,
and the presence of a fractional part does not change the essence of the
test.

What do you think?

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-03-11 10:03:34 Re: protocol support for labels
Previous Message Kirill Reshke 2025-03-11 09:48:01 Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring