Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
Date: 2025-01-24 14:14:59
Message-ID: daea5c30-19d7-455c-a9b4-1c0b5ea20eeb@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-01-24 Fr 3:04 AM, Srinath Reddy wrote:
>
>
> On Fri, Jan 24, 2025 at 1:42 AM Andrew Dunstan <andrew(at)dunslane(dot)net>
> wrote:
>
>
> `git blame` tells me that this switch statement goes back to 2001.
> Seeking a reason at this distance is unlikely to be productive.
> Probably
> we were not nearly as careful then as we are now about such
> things. Feel
> free to submit a patch tightening the test.
>
>
>
> Hi Andrew,
> thanks for the reply,here's the patch for the same.
>
>

I don't think we need a new file for this. pg_backup_utils.c is already
there for routines common to pg_restore and pg_dump.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-01-24 14:15:28 Re: Eagerly scan all-visible pages to amortize aggressive vacuum
Previous Message Joe Conway 2025-01-24 14:11:34 Re: Convert sepgsql tests to TAP