Re: Postgres perl module namespace

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Postgres perl module namespace
Date: 2021-09-04 13:58:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 9/4/21 2:19 AM, Noah Misch wrote:
> On Fri, Sep 03, 2021 at 03:34:24PM -0400, Andrew Dunstan wrote:
>> On 8/25/21 10:08 AM, Robert Haas wrote:
>>> On Wed, Aug 25, 2021 at 1:48 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>>> On Mon, Aug 23, 2021 at 03:39:15PM -0400, Robert Haas wrote:
>>>>> On Mon, Aug 23, 2021 at 3:03 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>>>> OK, I count 3 in favor of changing to PgTest::Cluster, 1 against,
>>>>>> remainder don't care.
>>>>> I'd have gone with something starting with Postgres:: ... but I don't care much.
>>>> PgTest seems like a better choice to me, as "Postgres" could be used
>>>> for other purposes than a testing framework, and the argument that
>>>> multiple paths makes things annoying for hackers is sensible.
>>> I mean, it's a hierarchical namespace. The idea is you do
>>> Postgres::Test or Postgres::<whatever> and other people using the
>>> Postgres database can use other parts of it. But again, not really
>>> worth arguing about.
>> I think I have come around to this POV. Here's a patch. The worst of it
>> is changes like this:
>> - my $node2 = PostgresNode->new('replica');
>> + my $node2 = Postgres::Test::Cluster->new('replica');
>> ...
>> - TestLib::system_or_bail($tar, 'xf', $tblspc_tars[0], '-C', $repTsDir);
>> + Postgres::Test::Utils::system_or_bail($tar, 'xf', $tblspc_tars[0], '-C', $repTsDir);
> plperl uses PostgreSQL:: as the first component of its Perl module namespace.
> We shouldn't use both PostgreSQL:: and Postgres:: in the same source tree, so
> this change should not use Postgres::.

Good point. Here's the same thing using PostgreSQL::Test



Andrew Dunstan

Attachment Content-Type Size
0001-move-perl-test-modules-to-PostgreSQL-Test-namespace.patch text/x-patch 165.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-09-04 14:18:24 Re: [PATCH] support tab-completion for single quote input with equal sign
Previous Message Gilles Darold 2021-09-04 11:00:58 Re: [PATCH] Hooks at XactCommand level