| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove a FIXME and unused variables in Meson |
| Date: | 2024-03-18 08:16:08 |
| Message-ID: | da6beba4-6ca5-4055-b4ee-ef11d9f44aef@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.03.24 06:13, Tristan Partin wrote:
> One of them adds version gates to two LLVM flags (-frwapv,
> -fno-strict-aliasing). I believe we moved the minimum LLVM version
> recently, so these might not be necessary, but maybe it helps for
> historictal reasons. If not, I'll just remove the comment in a different
> patch.
We usually remove version gates once the overall minimum required
version is new enough. So this doesn't seem like a step in the right
direction.
> Second patch removes some unused variables. Were they analogous to
> things in autotools and the Meson portions haven't been added yet?
Hmm, yeah, no idea. These were not used even in the first commit for
Meson support. Might have had a purpose in earlier draft patches.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-03-18 08:17:04 | Re: What about Perl autodie? |
| Previous Message | Dean Rasheed | 2024-03-18 08:01:03 | Re: MERGE ... RETURNING |