Re: pgindent vs. pgperltidy command-line arguments

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs. pgperltidy command-line arguments
Date: 2023-06-20 15:38:10
Message-ID: da2f7920-c12b-7e37-f87e-6c7bd5fd0f80@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-06-14 We 03:37, Peter Eisentraut wrote:
> On 25.05.23 15:20, Tom Lane wrote:
>> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> Until PG15, calling pgindent without arguments would process the whole
>>> tree.  Now you get
>>> No files to process at ./src/tools/pgindent/pgindent line 372.
>>> Is that intentional?
>>
>> It was intentional, cf b16259b3c and the linked discussion.
>>
>>> Also, pgperltidy accepts no arguments and always processes the whole
>>> tree.  It would be nice if there were a way to process individual files
>>> or directories, like pgindent can.
>>
>> +1, although I wonder if we shouldn't follow pgindent's new lead
>> and require some argument(s).
>
> That makes sense to me.  Here is a small update with this behavior
> change and associated documentation update.

I'm intending to add some of the new pgindent features to pgperltidy.
Preparatory to that here's a rewrite of pgperltidy in perl - no new
features yet but it does remove the hardcoded path, and requires you to
pass in one or more files / directories as arguments.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Attachment Content-Type Size
pgperltidy text/plain 921 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2023-06-20 16:08:33 Re: pgindent vs. pgperltidy command-line arguments
Previous Message Joel Jacobson 2023-06-20 14:56:12 Re: Do we want a hashset type?