| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables |
| Date: | 2025-05-19 08:17:55 |
| Message-ID: | d9e0389dad5767fb608eedbff001d56e@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your work and feedback!
I've updated the patches and added regular regression tests for
both pg_prewarm and amcheck.
On 2025-05-16 21:01, Fujii Masao wrote:
> Also, since the issue was introduced in v17, this patch should be
> back-patched to v17, right?
I agree with back-patching v3-0001. I was able to reproduce the issue
on the REL_17_STABLE branch. One concern is that this patch changes
the error message in production:
* v17.5 (without --enable-cassert)
> ERROR: fork "main" does not exist for this relation
* REL_17_STABLE with the v3-0001 patch (without --enable-cassert)
> ERROR: relation "test" does not have storage
However, I think preventing the assertion failure should take priority.
As for v3-0002, I think it's fine to apply it to the master branch only,
since it just makes a cosmetic improvement to the error message.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-assertion-failure-when-pg_prewarm-is-run-on-o.patch | text/x-diff | 3.9 KB |
| v3-0002-Fix-error-message-details-for-partitioned-indexes.patch | text/x-diff | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-05-19 09:05:08 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | jian he | 2025-05-19 07:05:04 | Re: support fast default for domain with constraints |