From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: error message when subscription target is a partitioned table |
Date: | 2018-12-06 02:34:19 |
Message-ID: | d9b809a3-54b8-85a5-2146-82f7251bcca4@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2018/12/06 11:28, Amit Langote wrote:
> On 2018/12/05 10:28, Amit Langote wrote:
>> On 2018/12/05 10:20, Michael Paquier wrote:
>>> On Tue, Dec 04, 2018 at 09:25:09AM +0100, Magnus Hagander wrote:
>>>> I think more people would directly understand the "is not a table" for a
>>>> foreign table than a partitioned one (for example, it does now show up in
>>>> \dt or under tables in pgadmin, but partitioned ones do). That said, if
>>>> it's not too complicated, I think including foreign tables as well would
>>>> definitely be useful, because it has table in the name. For the other
>>>> types, I agree they don't need to be special-cased, they are fine the way
>>>> they are.
>>>
>>> relkind is directly available in this code path, so it is not that hard
>>> to add. As you suggest, foreign tables make sense to add as those are
>>> actually *tables*. And it seems to me that we should also add toast
>>> tables for clarity for the same reason.
>>
>> Considering toast tables here seems like a stretch to me, because they're
>> not user defined. Chances of users adding a table to a publication whose
>> name matches that of a toast table's on the subscription side seems thin
>> too. Partitioned tables and foreign tables are user-defined and something
>> they'd expect to be handled appropriately.
>
> Attached updated patch that adds the check for foreign tables.
Adding to January CF.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2018-12-06 02:43:10 | Re: \gexec \watch |
Previous Message | Amit Langote | 2018-12-06 02:32:24 | Re: slight tweaks to documentation about runtime pruning |