From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: monitoring CREATE INDEX [CONCURRENTLY] |
Date: | 2019-02-13 05:03:46 |
Message-ID: | d96ecc31-4678-1e0f-5b06-c10ab15c676b@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019/02/13 4:16, Alvaro Herrera wrote:
> I added metrics for the validate_index phases; patch attached. This is
> still a bit raw, but it looks much better now. Here's a sample
> concurrent index build on a 100M tuple table. There are no concurrent
Great!
+ s.pid AS pid, S.datid AS datid, D.datname AS datname,
+ S.relid AS relid,
+ CASE s.param2 WHEN 0 THEN 'initializing (phase 1 of 8)'
+ WHEN 1 THEN 'waiting for lockers 1 (phase 2 of 8)'
+ WHEN 2 THEN 'building index (3 of 8): ' ||
+ pg_indexam_progress_phasename(s.param1::oid, s.param3)
It would be better to replace "s" with "S".
s/s.pid/S.pid/
s/s.param2/S.param2/
s/s.param1::oid, s.param3/S.param1::oid, S.param3/
These are not important comments but for readability. :)
Thanks,
Tatsuro Yamada
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-02-13 05:13:09 | Better error messages when lacking connection slots for autovacuum workers and bgworkers |
Previous Message | Amit Langote | 2019-02-13 04:57:09 | obsolete comment above index_pages_fetched |