Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Date: 2019-11-04 11:30:23
Message-ID: d8jimnzq3ow.fsf@dalvik.ping.uio.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> I just noticed that when contrib/seg was converted to V1 calling
>> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
>> in terms of PG_GETARG_POINTER(). But it itself calls DatumGetPointer(),
>> so shouldn't it be using PG_GETARG_DATUM()?
>
> Yup, I agree. Pushed.

Thanks!

> regards, tom lane

- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jehan-Guillaume de Rorthais 2019-11-04 11:42:35 Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug
Previous Message Amit Khandekar 2019-11-04 11:06:21 Re: Minimal logical decoding on standbys