Re: [PATCH] Alter or rename enum value

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Matthias Kurz <m(dot)kurz(at)irregular(dot)at>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>
Subject: Re: [PATCH] Alter or rename enum value
Date: 2016-08-18 10:43:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:

> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>> I was bored and thought "how hard could it be?", and a few hours'
>> hacking later, I have something that seems to work. It doesn't do IF
>> NOT EXISTS yet, and the error messaging could do with some improvement,
>> and there are no docs. The patch is attached, as well as at
> Here's v3 of the patch of the patch, which I consider ready for proper
> review. It now features:
> - IF (NOT) EXISTS support
> - Transaction support
> - Documentation
> - Improved error reporting (renaming a non-existent value to an existing
> one complains about the former, not the latter)

Here is v4, which changes the command from ALTER VALUE to RENAME VALUE,
for consistency with RENAME ATTRIBUTE.

Emre, I noticed you modified the commitfest entry
( to be for Andrew's
transactional enum addition patch instead, but didn't change the title.
I'll revert that as soon as it picks up this latest patch. Do you wish
to remain a reviewer for this patch, or should I remove you?

Attachment Content-Type Size
0001-Add-ALTER-TYPE-RENAME-VALUE-TO-v4.patch text/x-diff 17.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-08-18 10:46:55 Re: [PATCH] bigint txids vs 'xid' type, new txid_recent(bigint) => xid
Previous Message Magnus Hagander 2016-08-18 10:38:28 Re: Anyone want to update our Windows timezone map?