| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: perlcritic |
| Date: | 2017-03-01 16:21:54 |
| Message-ID: | d8ja89555nh.fsf@dalvik.ping.uio.no |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> I posted this about 18 months ago but then ran out of steam. [ ] Here
> is an updated patch. The testing instructions below still apply.
> Especially welcome would be ideas on how to address some of the places
> I have marked with ## no critic.
Attached is a patch on top of yours that addresses all the ## no critic
annotations except RequireFilenameMatchesPackage, which can't be fixed
without more drastic reworking of the plperl build process.
Tested on perl 5.8.1 and 5.24.0 by configuring with --with-perl and
--enable-tap-tests followed by make check-world, and running pgindent
--build.
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-most-perlcritic-exceptions.patch | text/x-diff | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2017-03-01 16:23:33 | Re: WAL logging problem in 9.4.3? |
| Previous Message | Tom Lane | 2017-03-01 16:18:34 | Re: Time to drop old-style (V0) functions? |