Re: Time to drop old-style (V0) functions?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Time to drop old-style (V0) functions?
Date: 2017-03-01 16:18:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-12-08 13:34:41 -0800, Andres Freund wrote:
>> Hi,
>> I'm wondering if it's not time for $subject:
>> - V0 causes confusion / weird crashes when PG_FUNCTION_INFO_V1 was
>> forgotten
>> - They have us keep weird hacks around just for the sake of testing V0
>> - they actually cost performance, because we have to zero initialize Datums, even if
>> the corresponding isnull marker is set.
>> - they allow to call arbitrary functions pretty easily
>> I don't see any reason to keep them around. If seriously doubt anybody
>> is using them seriously in anything but error.

I find these arguments pretty weak. In particular I don't buy your claim
that we could stop zero-initializing Datums, because I think we'd just
start getting valgrind complaints if we did. It's too common to copy both
a Datum and its isnull flag without any particular inquiry into whether
the datum is null.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= 2017-03-01 16:21:54 Re: perlcritic
Previous Message Andres Freund 2017-03-01 16:06:10 Re: Restricting maximum keep segments by repslots