| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_stat_ssl additions |
| Date: | 2018-11-28 17:31:59 |
| Message-ID: | d8e4e6d9-4007-e115-86aa-8d5c2679696d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/11/2018 22:41, Peter Eisentraut wrote:
>>> - Adds new fields to pg_stat_ssl: issuerdn and clientserial. These
>>> allow uniquely identifying the client certificate. AFAICT, these are
>>> the most interesting pieces of information provided by sslinfo but not
>>> in pg_stat_ssl. (I don't like the underscore-free naming of these
>>> fields, but it matches the existing "clientdn".)
>> clientdn, clientserial, issuerdn are the fields about client
>> certificates. Only the last one omits prefixing "client". But
>> "clientissuerdn" seems somewhat rotten... Counldn't we rename
>> clientdn to client_dn?
> I'd prefer renaming as well, but some people might not like that.
Any thoughts from others about whether to rename clientdn to client_dn
to allow better naming of the new fields?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2018-11-28 17:32:29 | Re: More issues with pg_verify_checksums and checksum verification in base backups |
| Previous Message | Peter Eisentraut | 2018-11-28 17:30:38 | Re: pg_stat_ssl additions |