Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

From: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"
Date: 2019-06-11 01:05:11
Message-ID: d8b0dbfd-5a95-7bb8-d440-73dc430c5284@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/11/19 2:33 AM, Alexander Korotkov wrote:
> On Sat, Jun 8, 2019 at 8:17 PM Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>> On Fri, Jun 7, 2019 at 6:02 PM Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> wrote:
>>> On 6/7/19 9:00 PM, Michael Paquier wrote:
>>>> On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote:
>>> > Or is that not worth bothering except on HEAD? Thoughts?
>>>
>>> Personally I don't think it's that critical, but not bothered either way.
>>> Presumably no-one has complained so far anyway (I only chanced upon the missing
>>> GUC description because I was poking about looking for examples of custom
>>> GUC handling...)
>>
>> I think it worth maintaining consistent documentation and GUC
>> descriptions in back branches. So, I'm +1 for backpatching.
>>
>> I'm going to commit all 3 patches (documentation, GUC description,
>> documentation indentation) on no objections.
>
> Pushed!

Thanks!

Regards

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-06-11 01:29:59 Re: BEFORE UPDATE trigger on postgres_fdw table not work
Previous Message Grace Kahinga 2019-06-11 00:44:58 Creating Introductory Resources as GSoD Project