Re: make -C libpq check fails obscurely if tap tests are disabled

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org
Cc: Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
Date: 2022-07-20 19:00:28
Message-ID: d8803a11-d525-b7b1-401a-2d296ea9d522@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-07-20 We 13:23, Justin Pryzby wrote:
> make -C ./src/interfaces/libpq check
> PATH=... && @echo "TAP tests not enabled. Try configuring with --enable-tap-tests"
> /bin/sh: 1: @echo: not found
>
> make is telling the shell to run "@echo" , rather than running "echo" silently.
>
> Since:
>
> commit 6b04abdfc5e0653542ac5d586e639185a8c61a39
> Author: Andres Freund <andres(at)anarazel(dot)de>
> Date: Sat Feb 26 16:51:47 2022 -0800
>
> Run tap tests in src/interfaces/libpq.

Yeah. It's a bit ugly but I think the attached would fix it.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
libpq-makefile-fix.patch text/x-patch 661 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-07-20 19:08:49 Re: shared-memory based stats collector - v70
Previous Message Greg Stark 2022-07-20 18:41:53 Re: shared-memory based stats collector - v70