| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [POC] A better way to expand hash indexes. |
| Date: | 2017-03-27 18:26:20 |
| Message-ID: | d87ed9ca-f859-bc96-c896-e866716ab380@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Mithun,
On 03/26/2017 01:56 AM, Mithun Cy wrote:
> Thanks, Amit for the review.
> On Sat, Mar 25, 2017 at 7:03 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> I think one-dimensional patch has fewer places to touch, so that looks
>> better to me. However, I think there is still hard coding and
>> assumptions in code which we should try to improve.
>
> Great!, I will continue with spares 1-dimensional improvement.
>
I ran some performance scenarios on the patch to see if the increased
'spares' allocation had an impact. I havn't found any regressions in
that regard.
Attached patch contains some small fixes, mainly to the documentation -
on top of v7.
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| hashbucket_fixes.patch | text/x-patch | 14.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Seltenreich | 2017-03-27 18:30:51 | Re: [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint |
| Previous Message | Alexander Korotkov | 2017-03-27 18:13:40 | Re: Unused argument in PinBuffer function |