| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused argument in PinBuffer function |
| Date: | 2017-03-27 18:13:40 |
| Message-ID: | CAPpHfdsfxOS4XNhLuNgSkG=1KtsHrmwcUn+HdAcphRc+WUBrYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 4, 2016 at 2:28 PM, Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> wrote:
> I was looking through the buffer manager's code and have noticed that
> function PinBuffer has an unused 'strategy' argument. It's seems that after
> refactoring made by Alexander Korotkov and Andres Freund
> (48354581a49c30f5757c203415aa8412d85b0f70) it became useless. The
> attached patch removes it. Probably someone more advanced could edit the
> function description to reflect changes?
>
48354581 contain unintentional change that made 'strategy' argument of
PinBuffer unused.
Since it was an unintentional change, it was decided to put old logic
back. See 9cf60332.
Thus, now 'strategy' argument of PinBuffer is used.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jesper Pedersen | 2017-03-27 18:26:20 | Re: [POC] A better way to expand hash indexes. |
| Previous Message | Tom Lane | 2017-03-27 17:47:02 | Re: logical replication launcher crash on buildfarm |