| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Sami Imseih <samimseih(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix bug in multixact Oldest*MXactId initialization and access |
| Date: | 2026-03-04 09:47:54 |
| Message-ID: | d820058d-1aec-4f7b-8d08-38e68ab3a91f@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2026 20:47, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> On 03/03/2026 17:22, Tom Lane wrote:
>>> I wonder if we couldn't reduce future maintenance effort for
>>> prepared_xacts_1.out by modifying that test script to make an
>>> early exit if prepared transactions are disabled.
>
>> +1, I was just thinking the same.
>
> Personally I'd put the exit test after the file's header comment,
> but that's just a quibble. LGTM otherwise.
Yeah I agree it would look a little neater, but I put the exit test
first so that the comment doesn't get echoed to the output when the test
isn't run. That way we don't need to remember to update
prepared_xacts_1.out if we change the header comment. It hasn't changed
for 20 years, but still :-).
Committed, thanks!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-03-04 09:50:40 | Re: pg_plan_advice (now with transparent SQL plan performance overrides - pg_stash_advice) |
| Previous Message | Álvaro Herrera | 2026-03-04 09:45:16 | Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement |