Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs
Date: 2024-01-17 16:46:24
Message-ID: d811bcaa-f88d-19a4-7926-df763c993c30@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-10-06 Fr 10:07, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> I don't have a good sense of what you are trying to optimize for. If
>> it's the mainline build-on-every-commit type, then I wonder how many
>> commits would really be affected by this. Like, how many commits touch
>> only a README file. If it's for things like the cfbot, then I think the
>> time-triggered builds would be more frequent than new patch versions, so
>> I don't know if these kinds of optimizations would affect anything.
> As a quick cross-check, I searched our commit log to see how many
> README-only commits there were so far this year. I found 11 since
> January. (Several were triggered by the latest round of pgindent
> code and process changes, so maybe this is more than typical.)
>
> Not sure what that tells us about the value of changing the CI
> logic, but it does seem like it could be worth the one-liner
> change needed to teach buildfarm animals to ignore READMEs.
>
> - trigger_exclude => qr[^doc/|\.po$],
> + trigger_exclude => qr[^doc/|/README$|\.po$],
>
>

I've put that in the sample config file for the next release.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-01-17 16:53:23 Re: More new SQL/JSON item methods
Previous Message Andrew Dunstan 2024-01-17 16:31:06 Re: psql JSON output format