| From: | Nicolai Tufar <ntufar(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [pgsql-hackers-win32] snprintf causes regression tests to fail |
| Date: | 2005-03-11 23:58:15 |
| Message-ID: | d809293905031115584b271b42@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
On Thu, 10 Mar 2005 19:21:41 -0500 (EST), Bruce Momjian
<pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > The CVS-tip implementation is fundamentally broken and won't work even
> > for our internal uses. I've not wasted time complaining about it
> > because I thought we were going to replace it. If we can't find a
> > usable replacement then we're going to have to put a lot of effort
> > into fixing what's there. On the whole I think the effort would be
> > better spent importing someone else's solution.
>
> Oh, so our existing implementation doesn't even meet our needs. OK.
Which made me wander why did I not aggree with
Tom Lane's suggestion to make do three passes
instead of two. Tom was right, as usual. It happened to
be much easier than I expected. The patch is attached.
Please apply.
Tom, what do you think? Will it be fine with you?
Best regards,
Nicolai
| Attachment | Content-Type | Size |
|---|---|---|
| snprintf.diff | text/x-patch | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satoshi Nagayasu | 2005-03-12 00:05:52 | partial vacuum |
| Previous Message | Bruce Momjian | 2005-03-11 22:26:26 | Re: Bumping libpq version number? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nicolai Tufar | 2005-03-12 15:00:14 | Re: [pgsql-hackers-win32] snprintf causes regression tests to fail |
| Previous Message | Bruce Momjian | 2005-03-11 21:30:59 | Re: [pgsql-hackers-win32] Repleacement for src/port/snprintf.c |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-03-12 02:03:41 | Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384 |
| Previous Message | Berényi Gábor | 2005-03-11 22:55:56 | Re: [INTERFACES] bcc32.mak for libpq broken? (distro 8.0.0) (fwd) |