Re: [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Nicolai Tufar <ntufar(at)gmail(dot)com>
Cc: Kurt Roeckx <kurt(at)roeckx(dot)be>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, devrim(at)gunduz(dot)org
Subject: Re: [pgsql-hackers-win32] Repleacement for src/port/snprintf.c
Date: 2005-03-11 21:30:59
Message-ID: 200503112130.j2BLUx725121@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches


I have reviewed this patch, and I already added these changes myself in
CVS.

Thanks.

---------------------------------------------------------------------------

Nicolai Tufar wrote:
> > On Mon, Feb 21, 2005 at 10:53:08PM -0500, Bruce Momjian wrote:
> >
> > Applied.
>
> Thanks a lot. The patch attached solves the tread
> safety problem. Please review it before applying,
> I am not sure I am doing the right thing
>
>
> On Tue, 22 Feb 2005 19:57:15 +0100, Kurt Roeckx <kurt(at)roeckx(dot)be> wrote:
> > The configure test is a little broken. It needs to quote the
> > $'s.
> >
> > I've rewritten the test a little.
>
> This one needs applying too. $'s do get scrambled.
>
> Best regards,
> Nicolai.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2005-03-11 21:39:59 Re: Bumping libpq version number?
Previous Message Bruce Momjian 2005-03-11 21:28:45 Re: [PATCHES] BUG #1466: syslogger issues

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-11 23:58:15 Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Previous Message Bruce Momjian 2005-03-11 17:44:19 Re: [pgsql-hackers-win32] snprintf causes regression

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-03-11 21:54:38 Re: [PATCHES] BUG #1466: syslogger issues
Previous Message Bruce Momjian 2005-03-11 21:28:45 Re: [PATCHES] BUG #1466: syslogger issues