Re: speeding up planning with partitions

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: speeding up planning with partitions
Date: 2019-01-07 09:17:07
Message-ID: d724e640-c197-e89f-85ea-e8e11625c48e@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks Justin for reporting the results of your testing.

On 2019/01/07 17:40, David Rowley wrote:
> On Fri, 4 Jan 2019 at 04:39, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>> Running 11dev with your v10 patch applied, this takes 2244ms with empty buffer
>> cache after postmaster restarted on a totally untuned instance (and a new
>> backend, with no cached opened files).
>>
>> I was curious why it took even 2sec, and why it did so many opens() (but not
>> 20k of them that PG11 does):
>
> It would be pretty hard to know that without seeing the query plan.

Yeah, I too would be curious to see if the resulting plan really needs to
do those open()s. If all the open()s being seen here are accounted for by
un-pruned partitions (across the UNION ALL) contained in the plan and
their indexes, then the patch has done enough to help. If the open()s can
be traced to pruned partitions, then there's something wrong with the patch.

Thanks,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2019-01-07 09:17:34 Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Previous Message Andrey Borodin 2019-01-07 09:12:03 Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line