| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: WaitEventSet resource leakage |
| Date: | 2023-11-22 13:00:00 |
| Message-ID: | d6c70225-6567-6617-351e-e9cdd73a11af@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
20.11.2023 00:09, Thomas Munro wrote:
> On Fri, Nov 17, 2023 at 12:22 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
>> And here is a patch to implement that on master.
> Rationale and code look good to me.
>
>
I can also confirm that the patches proposed (for master and back branches)
eliminate WES leakage as expected.
Thanks for the fix!
Maybe you would find appropriate to add the comment
/* Convenience wrappers over ResourceOwnerRemember/Forget */
above ResourceOwnerRememberWaitEventSet
just as it's added above ResourceOwnerRememberRelationRef,
ResourceOwnerRememberDSM, ResourceOwnerRememberFile, ...
(As a side note, this fix doesn't resolve the issue #17828 completely,
because that large number of handles might be also consumed
legally.)
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-11-22 13:06:34 | Re: Change GUC hashtable to use simplehash? |
| Previous Message | Ants Aasma | 2023-11-22 12:54:13 | Re: autovectorize page checksum code included elsewhere |