Re: Add id's to various elements in protocol.sgml

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Brar Piening <brar(at)gmx(dot)de>, Chapman Flack <chap(at)anastigmatix(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add id's to various elements in protocol.sgml
Date: 2022-03-02 09:37:36
Message-ID: d65e170d-0017-5c9c-fff7-fc8f5fb042c6@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.03.22 20:50, Brar Piening wrote:
> Patch is attached. I don't think it should get applied this way, though.
> The fact that you only get links for section headers that have manually
> assigned ids would be pretty surprising for users of the docs and in
> some files (e.g. protocol-flow.html) only every other section has a
> manually assigned id. It would be easy to emit a message (or even fail)
> whenever the template fails to find an id and then manually assign ids
> until they are everywhere (currently that means all varlistentries and
> sections) but that would a) be quite some work and b) make the patch
> quite heavy, so I wouldn't even start this before there is really
> consensus that this is the right direction.

I have applied the part of your patch that adds the id's. The
discussion about the formatting aspect can continue.

I changed the id's for the protocol messages to mixed case, so that it
matches how these are commonly referred to elsewhere. It doesn't affect
the output.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message osumi.takamichi@fujitsu.com 2022-03-02 09:38:47 RE: Optionally automatically disable logical replication subscriptions on error
Previous Message Amit Kapila 2022-03-02 09:25:55 Re: PG DOCS - logical replication filtering