Re: Support custom socket directory in pg_upgrade

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support custom socket directory in pg_upgrade
Date: 2018-11-30 18:24:07
Message-ID: d4b3e53a-6efd-b1f5-091c-ac02ae60e631@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30/11/2018 17:58, Tom Lane wrote:
> So we seem to be at an impasse here. By my count, three people have
> expressed support for the patch's approach of adding a socket-directory
> option, while two people seem to prefer the idea of putting pg_upgrade's
> socket under /tmp (possibly with a way to override that). That's not
> enough of a consensus to proceed with either approach, really, but
> we ought to do something because the problem is real.
>
> Given that we have a patch for this approach, and no patch has been
> offered for the /tmp approach, I'm kind of inclined to exercise
> committer's discretion and proceed with this patch. Will anybody
> be seriously annoyed if I do?

I think it's fair to proceed and leave open that someone submits a
(possibly) better patch for a different approach in the future.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-11-30 18:32:27 Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)
Previous Message Dmitry Dolgov 2018-11-30 17:27:05 Re: [HACKERS] WAL logging problem in 9.4.3?