Re: [buildfarm-members] BuildFarm client release 4.19

From: Mikael Kjellström <mikael(dot)kjellstrom(at)mksoft(dot)nu>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, buildfarm-members(at)postgresql(dot)org
Subject: Re: [buildfarm-members] BuildFarm client release 4.19
Date: 2017-05-01 19:19:44
Message-ID: d47618ea-6058-fa7f-d846-7dd505623f84@mksoft.nu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: buildfarm-members pgsql-hackers


On 2017-05-01 21:10, Andrew Dunstan wrote:
> Not sure I understand what "rerun a branch" from scratch means. If you
> zap the branch directory you lose all its state. That's generally a bad
> thing.

I mean like the first time when you set up the buildfarm client /
branch. And it's not something I recomend doing all the time but some
times when the buildfarm client doesn't clean up after it self and there
are a lot of crap left it's "easier" to just zap everything and start
over to get it running again.

> Anyway, this patch should fix it for all uses. It creates the directory
> if it doesn't exist.
>
> diff --git a/PGBuild/Utils.pm b/PGBuild/Utils.pm
> index 91c1362..175eaa7 100644
> --- a/PGBuild/Utils.pm
> +++ b/PGBuild/Utils.pm
> @@ -14,6 +14,8 @@ See accompanying License file for license details
> use strict;
> use warnings;
>
> +use File::Path;
> +
> use Exporter ();
> our (@ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
>
> @@ -30,8 +32,9 @@ use vars qw($VERSION); $VERSION = 'REL_4.19';
> sub run_log
> {
> my $command = shift;
> - my $file=
> -
> "$main::branch_root/$main::st_prefix$main::logdirname/lastcomand.log";
> + my $filedir =
> "$main::branch_root/$main::st_prefix$main::logdirname";
> + mkpath($filedir);
> + my $file= "$filedir/lastcomand.log";
> unlink $file;
> system("$command > $file 2>&1");
> my @loglines;

Ok.

Thanks. Will try it out.

/Mikael

In response to

Responses

Browse buildfarm-members by date

  From Date Subject
Next Message Mikael Kjellström 2017-05-01 19:43:58 Re: BuildFarm client release 4.19
Previous Message Andrew Dunstan 2017-05-01 19:10:32 Re: [buildfarm-members] BuildFarm client release 4.19

Browse pgsql-hackers by date

  From Date Subject
Next Message Mikael Kjellström 2017-05-01 19:43:58 Re: BuildFarm client release 4.19
Previous Message Andres Freund 2017-05-01 19:14:19 Re: snapbuild woes