| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Optimize btree insertions for common case of increasing values |
| Date: | 2018-04-10 22:37:54 |
| Message-ID: | d43ca132-132a-709f-cb44-ed913f68067f@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 04/10/2018 06:33 PM, Peter Geoghegan wrote:
> On Tue, Apr 10, 2018 at 3:27 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Committed with light editing. I didn't put the #define in the .h file -
>> it's only used here and that seemed like unnecessary clutter. I moved it
>> to the top of the file. I also standardized the spelling of "optimization".
> The comments still say "Check if the page...no split is in progress".
> Despite the fact that that's just an assertion now.
>
Fixed.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-04-10 22:39:46 | Re: pgsql: Optimize btree insertions for common case of increasing values |
| Previous Message | Andrew Dunstan | 2018-04-10 22:36:54 | pgsql: minor comment fixes in nbtinsert.c |