| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logical replication ApplyContext bloat |
| Date: | 2017-05-08 15:26:19 |
| Message-ID: | d422bdc8-ff02-c171-8dff-3e1fe52bdc89@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I'm not sure about some of the details.
I think it would make more sense to reset ApplyMessageContext in
apply_dispatch(), so that it is done consistently after every message
(as the name implies), not only some messages.
Also, perhaps ApplyMessageContext should be a child of
TopTransactionContext. (You have it as a child of ApplyContext, which
is under TopMemoryContext.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-05-08 15:27:08 | Re: Logical replication ApplyContext bloat |
| Previous Message | Dmitriy Sarafannikov | 2017-05-08 14:23:47 | Re: [PROPOSAL] Use SnapshotAny in get_actual_variable_range |