| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unique indexes on partitioned tables |
| Date: | 2018-02-14 03:58:35 |
| Message-ID: | d3e5cfa4-15aa-48a4-7b9e-49825a35b75c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is a mini-patch on top of yours to fix a few cosmetic things.
I don't understand the variable name "third". I don't see a "first" or
"second" nearby.
I find some of the columns in pg_constraint confusing. For a primary
key on a partitioned table, for the PK on the partition I get
conislocal = false, coninhcount = 1, connoinherit = true
The last part is confusing to me.
I don't know if that's really on this patch. But perhaps it could be
documented better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fixup-allow-indexes-on-partitioned-tables-to-be-uniq.patch | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-02-14 04:10:27 | Re: tapeblocks is uninitialized in logtape.c |
| Previous Message | Michael Paquier | 2018-02-14 03:32:48 | Re: Parallel bt build crashes when DSM_NONE |