Extra quote_all_identifiers in _dumpOptions

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Extra quote_all_identifiers in _dumpOptions
Date: 2019-06-27 09:12:15
Message-ID: d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello hackers,

While working on pg_dump I noticed the extra quote_all_identifiers in
_dumpOptions struct. I attached the patch.

It came from refactoring by 0eea8047bf. There is also a discussion:

Initially the patch proposed to use quote_all_identifiers of
_dumpOptions. But then everyone came to a decision to use global
quote_all_identifiers from string_utils.c, because fmtId() uses it.

Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
extra_quote_all_identifiers.patch text/x-patch 434 bytes


Browse pgsql-hackers by date

  From Date Subject
Next Message Darafei Komяpa Praliaskouski 2019-06-27 10:50:04 Re: GiST "choose subtree" support function to inline penalty
Previous Message Surafel Temesgen 2019-06-27 09:06:05 Re: FETCH FIRST clause PERCENT option