From: | NikhilS <nikkhils(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: StringInfo misc. issues |
Date: | 2007-08-30 06:01:02 |
Message-ID: | d3c4af540708292301p45027cand50aea3d29191dab@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Apologies! As Alvaro guessed it correctly I was working with 8.2 sources.
Sorry for the noise.
Regards,
Nikhils
On 8/29/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> NikhilS <nikkhils(at)gmail(dot)com> writes:
> > The attached patch should fix this.
>
> And break other things, no doubt. needed = 0 is a perfectly valid
> edge case and mustn't be rejected here. (In fact, I doubt you'd
> even get through the regression tests with this patch ... how much
> did you test it?)
>
> The real problem with what you describe is that you should have used
> makeStringInfo().
>
> > I also found the absence of a function like resetStringInfo() a bit
> > puzzling.
>
> CVS HEAD is way ahead of you.
>
> regards, tom lane
>
--
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-08-30 06:32:28 | Re: Why is there a tsquery data type? |
Previous Message | Tom Lane | 2007-08-30 04:33:03 | Re: Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment |