Re: StringInfo misc. issues

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: NikhilS <nikkhils(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: StringInfo misc. issues
Date: 2007-08-29 15:14:49
Message-ID: 784.1188400489@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

NikhilS <nikkhils(at)gmail(dot)com> writes:
> The attached patch should fix this.

And break other things, no doubt. needed = 0 is a perfectly valid
edge case and mustn't be rejected here. (In fact, I doubt you'd
even get through the regression tests with this patch ... how much
did you test it?)

The real problem with what you describe is that you should have used
makeStringInfo().

> I also found the absence of a function like resetStringInfo() a bit
> puzzling.

CVS HEAD is way ahead of you.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hans-Juergen Schoenig 2007-08-29 16:07:48 correct behavior of ANALYZE ...
Previous Message Alvaro Herrera 2007-08-29 15:11:06 Re: StringInfo misc. issues