| From: | NikhilS <nikkhils(at)gmail(dot)com> |
|---|---|
| To: | "Neil Conway" <neilc(at)samurai(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Date: | 2007-07-16 10:20:09 |
| Message-ID: | d3c4af540707160320j6b71ab89v25591c9e7ab7d4d9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hi,
> > You suppose "src_options" is much more readable than "inhreloptions"
> > or "inh_idxoptions"? Your call :).
>
> Yeah, I'm not necessarily sure that it is. "inhreloptions" made me think
> of table inheritance, whereas LIKE in general is more of a "source" =>
> "target" copying operation. But I'm not convinced about src_options,
> either ... suggestions/comments welcome.
>
I agree, since its a LIKE operation and not inheritance as such, how about
"src_idxoptions", just to make the reference to the source index
clearer? To reiterate its a minor nitpick really from my side and can
be ignored too.
Regards,
Nikhils
--
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2007-07-16 11:47:44 | Re: write_pipe_chunks patch messes up early error message output |
| Previous Message | Neil Conway | 2007-07-16 10:08:52 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2007-07-16 10:48:24 | Re: Deferred RI trigger for non-key UPDATEs and subxacts |
| Previous Message | Neil Conway | 2007-07-16 10:08:52 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |