| From: | NikhilS <nikkhils(at)gmail(dot)com> |
|---|---|
| To: | "Neil Conway" <neilc(at)samurai(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Date: | 2007-07-16 08:58:32 |
| Message-ID: | d3c4af540707160158r7069b30cs52da5f002a2ff673@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hi,
> Attached is a revised patch that does that. Barring any objections, I'll
> apply this to HEAD tomorrow.
>
A minor correction below in your patch:
--- src/include/commands/defrem.h 16 Jul 2007 05:19:43 -0000
*************** extern void DefineIndex(RangeVar *heapRe
*** 26,31 ****
--- 26,32 ----
List *options,
+ char *inhreloptions,
Guess you want to use "src_options" here to be uniform with usages
elsewhere that you have replaced. You suppose "src_options" is much
more readable than "inhreloptions" or "inh_idxoptions"? Your call :).
Regards,
Nikhils
--
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2007-07-16 10:08:52 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Neil Conway | 2007-07-16 07:46:39 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Affan Salman | 2007-07-16 09:20:56 | Re: Deferred RI trigger for non-key UPDATEs and subxacts |
| Previous Message | Magnus Hagander | 2007-07-16 08:41:14 | Re: BUG #3439: pg_standby and path name with space |