Re: Automatic cleanup of oldest WAL segments with pg_receivexlog

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Automatic cleanup of oldest WAL segments with pg_receivexlog
Date: 2017-03-04 04:09:05
Message-ID: d39bcee1-e028-ab3d-b4ed-acdc6574da46@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/27/17 00:32, Michael Paquier wrote:
> On Sun, Feb 26, 2017 at 8:24 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> To be consistent with archive_command and restore_command I'd rather
>> not do that. The command called can decide by itself what to do by
>> looking at the shape of the argument string.
> Just before the CF begins, I have taken some time to build up a patch
> that implements this --end-segment-command, with %f as placeholder.

I think this repeats all the mistakes of archive_command, which
ironically pg_receivexlog was intended to fix, such as: shell commands
not fully portable, improper fsync support, poor error handling, lack of
integration with synchronous replication, inability to handle multiple
actions properly.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-04 04:11:33 Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver
Previous Message Tomas Vondra 2017-03-04 04:02:29 Re: PATCH: two slab-like memory allocators